Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix(doc): update doc for testing with node 8 async/await and chrome inspector. #4613

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

qiyigg
Copy link
Contributor

@qiyigg qiyigg commented Dec 6, 2017

inspector.

@qiyigg qiyigg requested a review from vikerman December 6, 2017 01:16
@qiyigg qiyigg merged commit e51f0ec into angular:master Dec 6, 2017
@wswebcreation
Copy link
Contributor

wswebcreation commented Dec 6, 2017

Tnx, this is a clear documentation!!

@vsravuri
Copy link

@qiyigg @wswebcreation

Appreciate if an example is provided for Page Objects with Node 8 async/await

https://github.com/angular/protractor/blob/master/docs/page-objects.md

@qiyigg
Copy link
Contributor Author

qiyigg commented Dec 18, 2017

Hi,
For me, there's no difference in writing async/await test when using or not using Page Objects. Page Object is just a user wrapper to make your test more clear and stable.
But yes, it might have some problems if user doesn't understand async/await when they write tests using Page Objects.
Would you mind creating an issue, describe the requirement, and see if someone would like to write this? I don't think I could do it recently.
Thanks!

@vsravuri
Copy link

Sure, i will create a an issue.

@vsravuri
Copy link

@qiyigg

I have opened a new issue for documentation of Page Objects.

#4637

@qiyigg
Copy link
Contributor Author

qiyigg commented Dec 21, 2017

Thanks!

firstor pushed a commit to firstor/protractor that referenced this pull request Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants